Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Use $link-color instead of $brand-primary or active ListGroupItems #816

Merged
merged 1 commit into from
Feb 4, 2019
Merged

FIX Use $link-color instead of $brand-primary or active ListGroupItems #816

merged 1 commit into from
Feb 4, 2019

Conversation

robbieaverill
Copy link
Contributor

Restores white-on-blue background to text colour contrast in campaign-admin

Resolves silverstripe/silverstripe-campaign-admin#130

@robbieaverill
FIX Use $link-color instead of $brand-primary or active ListGroupItems
8a2b65d 
Restores white-on-blue background to text colour contrast in campaign-admin
@newleeland newleeland mentioned this pull request Feb 1, 2019
Closed
1 task
ScopeyNZ
ScopeyNZ approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@ScopeyNZ ScopeyNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colour looks good and I confirmed that it now meets accessibility standards.

@ScopeyNZ ScopeyNZ merged commit f7b7899 into silverstripe:1.3 Feb 4, 2019
@ScopeyNZ ScopeyNZ deleted the pulls/1.3/campaign-item-colour branch February 4, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScopeyNZ ScopeyNZ ScopeyNZ approved these changes

Assignees
No one assigned
Labels
affects/v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbieaverill @ScopeyNZ