-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests and styling for betterbuttons port #744
Add tests and styling for betterbuttons port #744
Conversation
44df9de
to
410956d
Compare
410956d
to
ef51328
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job on the Behat tests. Thank you!
Just a quick point on the javascript. As you've changed it, it has the potential to break other people's code, and I'm pretty sure it's not necessary.
35981ab
to
a84c765
Compare
How do we feel about getting some instant tooltips on these buttons? Not everyone's familiar with Looks beautiful but it does look like it differs a bit from the designs |
Hey, I've had a quick look at this and noticed it doesn't quite match the designs.
A few options for the icon:
Styleguide (click the preview link): https://projects.invisionapp.com/dsm/silver-stripe/silver-stripe/asset/components/5b5e610563c7ad0012bc21fb |
Great idea @ScopeyNZ 🙂 see updated Styleguide for tooltips. |
This is using our current button styling, we may want to discuss if we want this changed across all buttons to be consistent and possibly added to a separate issue, but I'm leaving this as is for now.
I tried this, and it works great, but I'm also worried about consistency here. This button is equivalent to the one shown on on the grid field so ideally they should be matching. I do think this new design looks slightly better, so maybe we can change the gridfield one to match the new one.
I'll see if I can add this to |
We have designed better buttons to work within the CMS with these new custom styles. We haven’t added any buttons without text yet in the CMS so because it's a new pattern we'd rather it look more cleaner rather than consistent. We hope to start using these styles throughout the CMS more often in the future. |
Fix tests and add check for discard confirmation
…iscard confirmation on search form bug
a84c765
to
5f52b60
Compare
Fixes #436