Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENHANCEMENT: Reverse argument signature of methods using path #698

Merged
merged 2 commits into from
Oct 18, 2018
Merged

ENHANCEMENT: Reverse argument signature of methods using path #698

merged 2 commits into from
Oct 18, 2018

Conversation

unclecheese
Copy link

robbieaverill
robbieaverill approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There were some docs too right?

@unclecheese unclecheese force-pushed the pulls/1.3/counter-argument branch from daab232 to fdf40dc Compare October 18, 2018 20:31
@unclecheese unclecheese merged commit 761a6f7 into silverstripe:1.3 Oct 18, 2018
@unclecheese unclecheese deleted the pulls/1.3/counter-argument branch October 18, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
affects/v4 type/api-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unclecheese @robbieaverill