Fix body overflow causing scroll bars #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinglozzer
commented
Oct 17, 2018
|
|
||
| .toggle-collapse, | ||
| .toggle-expand { | ||
| height: 54px; |
There was a problem hiding this comment.
As the parent .cms-panel-toggle is now always display: flex, these no longer need a hard-coded height as they’ll stretch automatically.
kinglozzer
commented
Oct 17, 2018
| height: 54px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; |
There was a problem hiding this comment.
To vertically centre the <span>»</span>, without relying on line-height hacks
robbieaverill
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #690. In my apparent tunnel vision, I failed to notice I’d broken the toggle for the SiteTree panel:
That toggle overflowing its container caused a vertical scrollbar on
<body>, this change fixes that. I’ve tested in IE11 and checked that this is the only other use of.cms-panel-togglein core.