NEW Tabs now store the active tab in redux state #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2018
7 tasks
raissanorth
force-pushed
the
pulls/1/change-active-tab-via-redux-form
branch
from
211cd51 to
46c9c28
Compare
raissanorth
force-pushed
the
pulls/1/change-active-tab-via-redux-form
branch
from
46c9c28 to
3769a48
Compare
raissanorth
force-pushed
the
pulls/1/change-active-tab-via-redux-form
branch
from
3769a48 to
0be4a9a
Compare
robbieaverill
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependant on framework PR: silverstripe/silverstripe-framework#8440
This PR changes the Tabs component to store the active tab in redux-form state. This allows components outside of the FormBuilder context to update the active tab with the redux-form action creators.
Additionally we've added an extension point to
FormBuilderLoaderthat will call a provided callback after the redux form is initialised. We've used this to set the initial tab as it's only known to the client-side.Related issue: silverstripe/silverstripe-elemental#325