Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG Ensure lang is detected from html tag #458

Merged
merged 1 commit into from
Mar 7, 2018
Merged

BUG Ensure lang is detected from html tag #458

merged 1 commit into from
Mar 7, 2018

Conversation

tractorcow
Copy link
Contributor

Replaces #421

I cleaned up all the linting in this file because it was horrible.

@tractorcow tractorcow mentioned this pull request Mar 7, 2018
Closed
@tractorcow tractorcow added this to the Recipe 4.0.4 milestone Mar 7, 2018
flamerohr
flamerohr approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@flamerohr flamerohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job cleaning up
Had to ignore whitespace changes before I could review

@flamerohr flamerohr merged commit 9722988 into silverstripe:1.0 Mar 7, 2018
@flamerohr flamerohr deleted the pulls/1.0/i18n-locale branch March 7, 2018 05:31
@tractorcow
Copy link
Contributor Author

Yeah indentation was legacy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamerohr flamerohr flamerohr approved these changes

Assignees
No one assigned
Labels
affects/v4 complexity/low impact/medium type/bug
Projects
None yet
Milestone
Recipe 4.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@tractorcow @flamerohr