Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Remove border-radius add hover states to non-active tabs #434

Merged
merged 1 commit into from
Feb 13, 2018
Merged

FIX Remove border-radius add hover states to non-active tabs #434

merged 1 commit into from
Feb 13, 2018

Conversation

sachajudd
Copy link
Contributor

Resolves: #383, silverstripe/silverstripe-asset-admin#689

Remove border-bottom, border-radius:
Before:
image

After:
image

Tab hovers:
Before:
image

After (hovered):
image

image

Files area:
Before (hovered):
image

After (hovered):
image

@dhensby
Copy link
Contributor

dhensby commented Feb 13, 2018 •
edited
Loading

Linting issues, I'm afraid

@dhensby dhensby merged commit 75ed323 into silverstripe:1.0 Feb 13, 2018
@sachajudd sachajudd deleted the pulls/1.0/fix-tabs branch February 13, 2018 20:01
@sachajudd
Copy link
Contributor Author

@dhensby cheers for fixing! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachajudd @dhensby