Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Correctly set img tag attributes for WYSIWYG #1798

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jul 28, 2024

The same fix as silverstripe/cwp#340 but for the default "cms" WYSIWYG config.

Fixes https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/10102090864/job/27937027096 and https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/10102090864/job/27937027255 in tandem with silverstripe/silverstripe-cms#2978

In this case for some reason the behat test was explicitly expecting no alt tag, though it's clear that the empty alt tag should be displayed.

Issue

@GuySartorelli GuySartorelli force-pushed the pulls/2.2/fix-wysiwyg-valid-elements branch from 49ed4c6 to 89a6923 Compare July 28, 2024 23:19
@GuySartorelli
Copy link
Member Author

@emteknetnz emteknetnz merged commit 806ba31 into silverstripe:2.2 Jul 29, 2024
14 of 16 checks passed
@emteknetnz emteknetnz deleted the pulls/2.2/fix-wysiwyg-valid-elements branch July 29, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants