FIX Clear filter from url state #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/1.13/clear-gridfield-search
branch
2 times, most recently
from
513f2fc to
88357e2
Compare
emteknetnz
force-pushed
the
pulls/1.13/clear-gridfield-search
branch
from
88357e2 to
d407f02
Compare
sabina-talipova
suggested changes
Sep 13, 2023
There was a problem hiding this comment.
Steve, it seems to me that now it doesn’t work quite the way it worked before. Because when search for smth and we go to the next level, for example, we click on one of the list elements and there we go to one of the nested lists and when we go back, we lose all the previous settings (filters, sorting and pagination).
Screen.Recording.2023-09-13.at.1.56.49.PM.mov
| @@ -23,3 +28,15 @@ Feature: Search in GridField | |||
| And I click "Walmart" in the "#Form_EditForm" element | |||
| Then I should see "Walmart" | |||
| And I should see "Walmart" in the ".breadcrumbs-wrapper" element | |||
|
|
|||
| @sboyd | |||
There was a problem hiding this comment.
Suggested change
| @sboyd |
emteknetnz
force-pushed
the
pulls/1.13/clear-gridfield-search
branch
from
d407f02 to
594db46
Compare
|
I think this is an existing behaviour, I can replicated that on 4.13 without this pull-request The gridState is lost when you view the individual employee "Troy" |
sabina-talipova
suggested changes
Sep 14, 2023
client/src/legacy/GridField.js
Outdated
| // aggressive in removing their state. This limitation is because I couldn't find an | ||
| // easy way to extract the gridfield number from the gridfield | ||
| if (key.match(new RegExp(`^gridState\\-${gridFieldName}\\-[0-9]$`))) { | ||
| console.log('Removing ' + key); |
There was a problem hiding this comment.
Suggested change
| console.log('Removing ' + key); |
|
There are also some failed tests. Please, have a look. |
emteknetnz
force-pushed
the
pulls/1.13/clear-gridfield-search
branch
4 times, most recently
from
fa1b4ae to
0d7985b
Compare
emteknetnz
force-pushed
the
pulls/1.13/clear-gridfield-search
branch
from
0d7985b to
9ba03f3
Compare
sabina-talipova
suggested changes
Sep 15, 2023
emteknetnz
force-pushed
the
pulls/1.13/clear-gridfield-search
branch
3 times, most recently
from
b9c7088 to
7ed648b
Compare
sabina-talipova
suggested changes
Sep 19, 2023
emteknetnz
force-pushed
the
pulls/1.13/clear-gridfield-search
branch
from
7ed648b to
0b7d69b
Compare
emteknetnz
force-pushed
the
pulls/1.13/clear-gridfield-search
branch
from
0b7d69b to
f9a151f
Compare
sabina-talipova
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1573
Requires the following PRs merged first:
Installer run with all 3x PRs together:
Have run
yarn upgrade webpackbecause js build was randomly failing - relates to #1582