MNT Add behat test for form validation #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2023
GuySartorelli
force-pushed
the
pulls/1.13/behat-for-validation
branch
from
c61ddbd to
1b8b5d9
Compare
sabina-talipova
suggested changes
Aug 9, 2023
There was a problem hiding this comment.
Could we check another fields, not just Email.
There was a problem hiding this comment.
We can, but can you please explain why? We're not testing if all form fields have implemented good validation logic - we're just testing if the form is validated at all when we don't explicitly declare a validator. The type of the field isn't really relevant.
sabina-talipova
approved these changes
Aug 9, 2023
|
Guy, could you, please, check this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#10907 and silverstripe/silverstripe-frameworktest#146 to be merged in before it will go green
Note that I'm not checking toasts in the behat test because it turns out there are none to check! See #1544
Issue