Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API phpunit 9 support #1259

Merged
merged 1 commit into from
Oct 27, 2021
Merged

API phpunit 9 support #1259

merged 1 commit into from
Oct 27, 2021

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as draft October 12, 2021 02:55
@emteknetnz emteknetnz mentioned this pull request Oct 12, 2021
Closed
93 tasks
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch 8 times, most recently from 18ffc4c to 2286dc9 Compare October 19, 2021 21:29
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch 2 times, most recently from 6efe086 to 2c059c6 Compare October 21, 2021 00:10
@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 00:59
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from 2c059c6 to 34460c5 Compare October 27, 2021 00:11
maxime-rainville
maxime-rainville approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to re-run the tests. But otherwise, it looks good.

composer.json Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch 2 times, most recently from 0c4ccea to 1f42fb9 Compare October 27, 2021 04:50
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from 1f42fb9 to 6ba9b94 Compare October 27, 2021 05:21
@emteknetnz emteknetnz merged commit 9d18c53 into silverstripe:1 Oct 27, 2021
@emteknetnz emteknetnz deleted the pulls/1/sapphire-test-nine branch October 27, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville