BUG: Always continue loading scripts even if one script fails.

This is especially important so that the deferred callbacks are triggered in the end. Also show error messages of JS scripts that failed loading, rather than failing silently.
silverstripe · Dec 12, 2018 · e624376 · e624376
1 parent 78cafb9
commit e624376
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/client/dist/js/vendor.js b/client/dist/js/vendor.js
diff --git a/thirdparty/jquery-ondemand/jquery.ondemand.js b/thirdparty/jquery-ondemand/jquery.ondemand.js
@@ -123,10 +123,13 @@
 					$.ajax({
 						dataType: 'script',
 						url: newJsInclude,
-						success: function() {
+						complete: function() {
 							self._ondemand_loaded_list[newJsInclude] = 1;
 							getScriptQueue();
 						},
+						error: function(xhr, status, error) {
+							console.error(error);
+						},
 						cache: false,
 						// jQuery seems to override the XHR objects if used in async mode
 						async: false