DEP Add silverstripe/linkfield #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
I'm strongly against doing this so early on. This is meant to be a way to ensure that core and supported modules don't break each other. Linkfield is neither supported nor core, and has a long way to go before it's either. |
|
OK I'll pop the PR it into draft for now |
13 tasks
GuySartorelli
force-pushed
the
pulls/5/linkfield
branch
from
357ad61 to
fa436ba
Compare
|
Force pushed to rerun CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-linkfield#95
Requires silverstripe/silverstripe-linkfield#100 to be merged first to get the linkfield unit tests passing