DEP Use caret for silverstripe/recipe-plugin #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/caret
branch
from
cac14a8 to
36483f4
Compare
|
I think this MFA failure is new? Not mentioned in https://github.com/silverstripeltd/product-issues/issues/672 |
|
It does seem new. But it's unrelated to this PR. |
GuySartorelli
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-installer#341
Note CMS 4 does define recipe-plugin even though silverstripe/installer does - https://github.com/silverstripe/recipe-kitchen-sink/blob/4/composer.json#L9 -
This is possibly because it needs to load "before" other things, I'm not sure. It's fairly harmless leaving it here regardless
Failing unit tests are unrelated