API phpunit 9 support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 tasks
emteknetnz
force-pushed
the
pulls/1/sapphire-test-nine
branch
from
e7d16c5 to
52448e2
Compare
emteknetnz
force-pushed
the
pulls/1/sapphire-test-nine
branch
from
52448e2 to
830050a
Compare
maxime-rainville
approved these changes
Nov 8, 2021
emteknetnz
force-pushed
the
pulls/1/sapphire-test-nine
branch
from
830050a to
9cc67ec
Compare
|
@maxime-rainville ^ failing test requires releasing a new minor of silvestripe/gridfieldqueuedexport because it's a ^ rather that an .x-dev requirement - https://github.com/silverstripe/silverstripe-gridfieldqueuedexport/pull/57/files - though that requires framework ^4.10 which is unreleased We should probably merge this with broken test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10019