Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Remove resources-dir config from composer.json #59

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Aug 3, 2022

@michalkleiner
Copy link

michalkleiner commented Aug 3, 2022

At first, I was alarmed why we were removing the config, then I had to go and check the parent issue and only there I find the default would change so the config won't be needed anymore if merged in the correct order. It might be worth updating the title of the follow-up PRs to that effect or at least the description of the code change.

@GuySartorelli
Copy link
Member Author

This is in draft in part because I didn't notice the config wasn't meant to be removed until after I did most of the work. 😅
Pending clarification

@GuySartorelli
Copy link
Member Author

To clarify: The config being removed from these composer.json files is correct.
The default is being changed in framework and in vendor-plugin.

I think this PR's title is correct.
The PRs for framework/vendor-plugin have been swapped out for the correct functionality change and the titles for those are correspondingly correct for the changes being made in those repos.

@GuySartorelli GuySartorelli changed the base branch from 4 to 5 August 4, 2022 05:12
@GuySartorelli GuySartorelli marked this pull request as ready for review August 4, 2022 05:12
@emteknetnz emteknetnz merged commit b61004e into silverstripe:5 Aug 5, 2022
@emteknetnz emteknetnz deleted the pulls/5/canonical-resources branch August 5, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants