Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Allow graphql 3.8 dev dependency #56

Merged
merged 1 commit into from
May 9, 2022
Merged

DEP Allow graphql 3.8 dev dependency #56

merged 1 commit into from
May 9, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz changed the base branch from 4 to 4.11 May 9, 2022 05:04
@emteknetnz emteknetnz changed the title Pulls/4.11/g3g4 DEP Allow graphql 3.8 dev dependency May 9, 2022
GuySartorelli
GuySartorelli approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows either version, defaults to v4 but allows v3 via composer.json.
Looks good.

@GuySartorelli GuySartorelli merged commit b68e221 into silverstripe:4.11 May 9, 2022
@GuySartorelli GuySartorelli deleted the pulls/4.11/g3g4 branch May 9, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli