Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API phpunit 9 support #51

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch from 47d343f to 0fbec62 Compare October 19, 2021 01:29
@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch from 0fbec62 to afd98f8 Compare October 27, 2021 22:47
@emteknetnz emteknetnz marked this pull request as ready for review November 3, 2021 22:14
@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch from afd98f8 to ef2201f Compare November 4, 2021 20:47
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... I just restarted the build to see if it passes now.

@emteknetnz
Copy link
Member Author

^ failing versioned build would have been resolved with silverstripe/silverstripe-versioned#345 being merged

@emteknetnz emteknetnz merged commit 4472888 into silverstripe:4 Nov 9, 2021
@emteknetnz emteknetnz deleted the pulls/4/sapphire-test-nine branch November 9, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants