Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API phpunit 9 support #28

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch 4 times, most recently from 92a3efd to 6c2b5c2 Compare October 20, 2021 23:59
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from 6c2b5c2 to 7c36fcd Compare November 3, 2021 22:11
@emteknetnz emteknetnz marked this pull request as ready for review November 3, 2021 22:15
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... just restarted build

@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch 2 times, most recently from 990547b to 491eeb0 Compare November 9, 2021 04:37
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from 491eeb0 to 09ea4ab Compare November 9, 2021 20:50
@emteknetnz
Copy link
Member Author

Broken unit test requires merging silverstripe/silverstripe-widgets#187 first, then rerun test in travis

@maxime-rainville maxime-rainville merged commit 93fba1f into silverstripe:1 Nov 10, 2021
@maxime-rainville maxime-rainville deleted the pulls/1/sapphire-test-nine branch November 10, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants