Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Don't use --exclude-filter for PHPUnit 9 #43

Merged
merged 1 commit into from
Sep 30, 2024
Merged

FIX Don't use --exclude-filter for PHPUnit 9 #43

merged 1 commit into from
Sep 30, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Sep 30, 2024
Closed
emteknetnz
emteknetnz requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a separate block for this checking for if (( "$INT_VERSION" >= 110300 )); then because we're using ^11.3 for CMS 6, so it'll use 11.3.0 for the --prefer-lowest builds.

@GuySartorelli GuySartorelli force-pushed the pulls/1.2/fix-framework-core branch from 12c4892 to aa6c543 Compare September 30, 2024 01:49
@GuySartorelli
Copy link
Member Author

Done

@emteknetnz emteknetnz merged commit f38e829 into silverstripe:1.2 Sep 30, 2024
2 checks passed
@emteknetnz emteknetnz deleted the pulls/1.2/fix-framework-core branch September 30, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz