FIX Use installer for silverstripe/serve and silverstripe/behat-exten… #80
Conversation
job_creator.php
Outdated
| if (!isset($json->type) || !in_array($json->type, $silverstripeRepoTypes)) { | ||
| return ''; |
There was a problem hiding this comment.
This condition is the one we want to skip, not the file_exists condition above. We should still look for silverstripe-related dependencies to guess the installer version.
There was a problem hiding this comment.
Do these repos not also need dev/build run? If they do, we need to update needs_full_setup.
If they don't need that, then we should just add installer as an explicit dev dependencies for the relevant repositories (as mentioned in the description of the PR that introduced this condition)
Whenever we add a new repository that isn't a module/recipe/theme, we have to update a constant in order to tell the matrix generator not to add installer for it.
Instead of doing that, the generator just shouldn't try to add installer for those. Anything that isn't a recipe, a module, or a theme but which needs installer for its tests to run should explicitly add installer as a dev dependency.
There was a problem hiding this comment.
I've moved the !in_array($this->repoName, FORCE_INSTALLER_UNLOCKEDSTEPPED_REPOS) to here.
End result is that serve + behat-extension will still get installer dynamically added as a dep in CI
explicit dev dependencies for the relevant repositories
But installer is not a real dev dependency. I also don't want to touch either serve + behat-extension because they're both fine, issue is just CI
emteknetnz
force-pushed
the
pulls/1.12/behat-serve
branch
from
501096b to
9fa6a4c
Compare
emteknetnz
force-pushed
the
pulls/1.12/behat-serve
branch
from
9fa6a4c to
d200dc4
Compare
Issue silverstripe/.github#188
silverstripe/serve and silverstripe/behat-extension used to get silverstripe/installer installed, now they don't and their CI stopped working