FIX Ensure recipes get databases set up #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/1.12/setup-for-recipes
branch
from
2c23c44 to
7646c3f
Compare
GuySartorelli
force-pushed
the
pulls/1.12/setup-for-recipes
branch
from
7646c3f to
bfdb9b2
Compare
GuySartorelli
commented
Jan 29, 2024
Comment on lines
-24
to
+26
| $repo = explode('/', $this->githubRepository)[1]; | ||
| $this->repoName = explode('/', $this->githubRepository)[1]; |
There was a problem hiding this comment.
This is needed so that we have access to the repo name in createJob() - and since we now have this property we should use it wherever else we need the repo name as well.
emteknetnz
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #77 I forgot that recipes don't install installer - so we need to make sure that for modules in the
NO_INSTALLER_LOCKSTEPPED_REPOSconstant we are also allowing full setup.See silverstripe/gha-ci#97 (comment) - only the recipe runs are failing.
Issue