Skip to content

Commit

Permalink
ENH Add new marker to avoid unnecessary setup (#77)
Browse files Browse the repository at this point in the history
  • Loading branch information
@GuySartorelli
GuySartorelli authored Jan 28, 2024
1 parent b6cb670 commit cdeaecd
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
1 change: 1 addition & 0 deletions job_creator.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ public function createJob(int $phpIndex, array $opts): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => false,
'needs_full_setup' => $this->installerVersion !== '',
];
return array_merge($default, $opts);
}
Expand Down
13 changes: 13 additions & 0 deletions tests/JobCreatorTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public function provideCreateJob(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => false,
'needs_full_setup' => false,
]],
// test that NO_INSTALLER_LOCKSTEPPED_REPOS base max PHP version from $branch
['myaccount/silverstripe-installer', '4.10', 99, [], [
Expand Down Expand Up @@ -193,6 +194,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '7.4 prf-low mysql57 phpunit all',
],
[
Expand All @@ -211,6 +213,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.0 mysql57pdo phpunit all',
],
[
Expand All @@ -229,6 +232,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.1 mysql80 phpunit all',
],
]
Expand Down Expand Up @@ -259,6 +263,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.1 prf-low mysql57 phpunit all',
],
[
Expand All @@ -276,6 +281,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.2 mariadb phpunit all',
],
[
Expand All @@ -293,6 +299,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.3 mysql80 phpunit all',
],
]
Expand Down Expand Up @@ -323,6 +330,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.1 prf-low mysql57 phpunit all',
],
[
Expand All @@ -340,6 +348,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.1 mariadb phpunit all',
],
[
Expand All @@ -357,6 +366,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.2 mysql80 phpunit all',
],
]
Expand Down Expand Up @@ -387,6 +397,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.1 prf-low mysql57 phpunit all',
],
[
Expand All @@ -404,6 +415,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.2 mariadb phpunit all',
],
[
Expand All @@ -421,6 +433,7 @@ public function provideCreateJson(): array
'endtoend_suite' => 'root',
'endtoend_config' => '',
'js' => 'false',
'needs_full_setup' => 'true',
'name' => '8.3 mysql80 phpunit all',
],
]
Expand Down

0 comments on commit cdeaecd

Please sign in to comment.