Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Use day of year instead of day of week #4

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 5, 2023

Issue silverstripe/recipe-kitchen-sink#44

Instead of running on 5 and 4.13 branches, repos with crons detp to run on Sunday + Monday will always run the 5 branch and never the 4.13 branch/ We use mod 2 to detect if the day of week is odd or even to work out which branch to run on. Sunday + Monday bother return the same value

This PR changes this to day of year instead

This was referenced Jul 5, 2023
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution

@GuySartorelli GuySartorelli merged commit 1322ccb into silverstripe:1.0 Jul 5, 2023
@GuySartorelli GuySartorelli deleted the pulls/1.0/weekly branch July 5, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants