NEW Install extra PHP extensions for some unit tests #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/1/in-memory-cache
branch
11 times, most recently
from
06b1eb7 to
bf6a245
Compare
emteknetnz
requested changes
Jul 11, 2024
emteknetnz
requested changes
Jul 11, 2024
GuySartorelli
force-pushed
the
pulls/1/in-memory-cache
branch
from
bf6a245 to
067ae22
Compare
emteknetnz
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install_inmemory_cache_extscan be set to true inextra_jobs- doing so adds the necessary requirements for all three in-memory cache adapters to be checked in the new unit test (see https://github.com/silverstripe/silverstripe-framework/pull/11300/files#diff-c45f7dfcc60b4ba10d58981503d905eb32b9415cb3883f13aae632767dcaf390).The new
phpunit_skip_suitesinput is added so that we can have those extra dependencies only for the unit tests that need them.We don't actually need to have a memcached or redis server running - we're not testing that the symfony adapters work, that's symfony's job. We just need the prerequisites to be met so we can instantiate the adapters, to check the correct adapters do get instantiated.
See https://github.com/GuySartorelli/silverstripe-framework/actions/runs/9850069049/job/27195842069 for a test run which shows this works fine as far as installing everything.
Note that the framework PR requires other PRs to go green, so that's what all the red is about. The important thing is that it gets passed both "Configure PHP" and "Composer", and that only the one extra cache CI run exists.
Issue