ENH Update stylelint rules #26
Conversation
GuySartorelli
force-pushed
the
pulls/1/update-stylelint-rules
branch
from
23338a5 to
f0e12f6
Compare
| 'selector-class-pattern': null, | ||
| 'function-no-unknown': null, | ||
| 'property-no-vendor-prefix': null, | ||
| 'value-no-vendor-prefix': null, | ||
| 'font-family-no-missing-generic-family-keyword': null, | ||
| 'scss/dollar-variable-colon-space-after': null, | ||
| 'scss/no-global-function-names': null, | ||
| 'value-keyword-case': null | ||
| 'value-keyword-case': null, | ||
| 'media-query-no-invalid': null, |
There was a problem hiding this comment.
As per https://stylelint.io/user-guide/rules/media-query-no-invalid/ this rule isn't appropriate for scss
GuySartorelli
force-pushed
the
pulls/1/update-stylelint-rules
branch
3 times, most recently
from
3f436af to
f857181
Compare
GuySartorelli
force-pushed
the
pulls/1/update-stylelint-rules
branch
from
f857181 to
7597c64
Compare
| 'selector-max-compound-selectors': 5, | ||
| 'selector-max-compound-selectors': 6, |
There was a problem hiding this comment.
Bumped slightly to resolve a lot of issues and avoid having to add a ignore comments for all of them.
This rule can't be retrospectively respected without changing the specificity of selectors, which might affect styling in adverse ways.
| 'max-nesting-depth': [ | ||
| 3, | ||
| 4, |
There was a problem hiding this comment.
Bumped slightly to resolve a lot of issues and avoid having to add a ignore comments for all of them.
Respecting this rule retrospectively would require refactoring the scss in a way that could result in unexpected changes
| 'selector-class-pattern': null, | ||
| 'selector-id-pattern': null, |
There was a problem hiding this comment.
We can't change what the IDs look like at this point, it's too likely to cause problems.
| 'selector-id-pattern': null, | ||
| 'keyframes-name-pattern': null, | ||
| 'scss/dollar-variable-pattern': null, |
There was a problem hiding this comment.
A mixture of "changing these could cause problems" and "changing these isn't worth the effort, it doesn't really matter if they match some arbitrary pattern or not"
| 'scss/at-extend-no-missing-placeholder': null, | ||
| 'no-descending-specificity': null, |
There was a problem hiding this comment.
no-descending-specificity was the single most common item failing linting, and respecting it retrospectively could result in unexpected changes in styling.
scss/at-extend-no-missing-placeholder means we can't use @extend to avoid duplication of code for class selectors - in some cases this would even mean duplicating bootstrap css which we definitely don't want to do. Best to just disable the rule.
|
Tagged and published as 1.3.0 |
After merging:
1.3branch1.3.0on GitHub1.3.0to npm viayarn publishIssue