Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Document bootstrap upgrade #679

Merged
merged 1 commit into from
Jan 26, 2025
Merged

DOC Document bootstrap upgrade #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions en/08_Changelogs/6.0.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,6 +878,18 @@ Several JavaScript dependencies have been updated, and a few have been replaced.

Notably, [`react-dnd`](https://react-dnd.github.io/react-dnd/about) has been replaced with [`dnd-kit`](https://dndkit.com/). If you were using `react-dnd` and relying on the webpack externals provided by `silverstripe/admin`, these are no longer available. We recommend refactoring your code to use `dnd-kit` so that your UX is consistent with other drag-and-drop in the CMS.

#### Bootstrap upgrade

We have upgraded from bootstrap 4 to bootstrap 5. Part of this upgrade also included upgrading reactstrap from 8 to 9 and upgrading popperjs from 1 to 2.

Refer to the following upgrade guides for details about changes you may need to make to styling and JavaScript in your CMS customisations:

- [bootstrap upgrade guide](https://getbootstrap.com/docs/5.0/migration/)
- [reactstrap upgrade guide](https://reactstrap.github.io/?path=/story/home-upgrading--page)
- [popper upgrade guide](https://popper.js.org/docs/v2/migration-guide/)

Note that while the bootstrap guide mentions removing the styling for the `.form-group`, `.form-row`, or `.form-inline` CSS classes, that styling has been included in the CMS to reduce upgrade pain.

## Bug fixes

This release includes a number of bug fixes to improve a broad range of areas. Check the change logs for full details of these fixes split by module. Thank you to the community members that helped contribute these fixes as part of the release!
Expand Down
4 changes: 2 additions & 2 deletions en/10_Contributing/05_Coding_Conventions/03_CSS_Coding_Conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ Check our [requirements](/getting_started/server_requirements) documentation.
## Tools and libraries

Styles are written in the [SCSS language](https://sass-lang.com/).
We use [Bootstrap 4](https://getbootstrap.com/) styles where possible.
We use [Bootstrap 5](https://getbootstrap.com/) styles where possible.

## Conventions

We follow the [AirBnB CSS Conventions](https://github.com/airbnb/css)
and the [BEM](https://getbem.com/) methodology (block-element-modifier).

Because we use [Bootstrap 4](https://getbootstrap.com/) which
Because we use [Bootstrap 5](https://getbootstrap.com/) which
does not follow [BEM](https://getbem.com/) naming convention there will be
a lot of places where class names voilate BEM.
However, please note that they are not a indicator of how to name classes.
Expand Down
Loading