DOC Add validations related to DBField #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
emteknetnz
force-pushed
the
pulls/5/api-depr
branch
from
90e438f to
2c1c563
Compare
GuySartorelli
requested changes
Oct 21, 2024
en/08_Changelogs/5.4.0.md
Outdated
| @@ -102,6 +102,8 @@ SilverStripe\ORM\FieldType\DBPolymorphicForeignKey: | |||
| - [`HTTPOutputHandler::isCli()`](api:SilverStripe\Logging\HTTPOutputHandler::isCli()) has been deprecated. Use [`Director::is_cli()`](api:SilverStripe\Control\Director::is_cli()) instead instead. | |||
| - [`PasswordValidator`](api:SilverStripe\Security\PasswordValidator) has been deprecated. It will be renamed to `SilverStripe\Security\Validation\RulesPasswordValidator`. | |||
| - [`ContentReviewEmails::isValidEmail()`](api:SilverStripe\ContentReview\Tasks\ContentReviewEmails::isValidEmail()) has been deprecated. Use [`Email::is_valid_address()`](api:SilverStripe\Control\Email\Email::is_valid_address()) instead. | |||
| - [`DBField.defaultVal`](api:SilverStripe\ORM\FieldType\DBField->defaultVal). Use getDefaultValue() and setDefaultValue() instead. | |||
There was a problem hiding this comment.
Suggested change
| - [`DBField.defaultVal`](api:SilverStripe\ORM\FieldType\DBField->defaultVal). Use getDefaultValue() and setDefaultValue() instead. | |
| - The [`DBField.defaultVal`](api:SilverStripe\ORM\FieldType\DBField->defaultVal) property has been deprecated. Use getDefaultValue() and setDefaultValue() instead. |
Also make getDefaultValue() and setDefaultValue() into links.
en/08_Changelogs/5.4.0.md
Outdated
| @@ -102,6 +102,8 @@ SilverStripe\ORM\FieldType\DBPolymorphicForeignKey: | |||
| - [`HTTPOutputHandler::isCli()`](api:SilverStripe\Logging\HTTPOutputHandler::isCli()) has been deprecated. Use [`Director::is_cli()`](api:SilverStripe\Control\Director::is_cli()) instead instead. | |||
| - [`PasswordValidator`](api:SilverStripe\Security\PasswordValidator) has been deprecated. It will be renamed to `SilverStripe\Security\Validation\RulesPasswordValidator`. | |||
| - [`ContentReviewEmails::isValidEmail()`](api:SilverStripe\ContentReview\Tasks\ContentReviewEmails::isValidEmail()) has been deprecated. Use [`Email::is_valid_address()`](api:SilverStripe\Control\Email\Email::is_valid_address()) instead. | |||
| - [`DBField.defaultVal`](api:SilverStripe\ORM\FieldType\DBField->defaultVal). Use getDefaultValue() and setDefaultValue() instead. | |||
| - [`DBFile::validate()`](api:SilverStripe\Assets\Storage\DBFile::validate()) has been deprecated. Use validateFilename() instead. | |||
There was a problem hiding this comment.
validateFilename() should be a link.
emteknetnz
force-pushed
the
pulls/5/api-depr
branch
from
2c1c563 to
3076730
Compare
emteknetnz
force-pushed
the
pulls/5/api-depr
branch
from
3076730 to
d01a317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11403
Linting issue is existing