Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update typehints in docs #569

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

GuySartorelli
Copy link
Member

- [Dependency changes](#dependency-changes)
- [`intervention/image` has been upgraded from v2 to v3](#intervention-image)
- [Bug fixes](#bug-fixes)
- [API changes](#api-changes)
- [Most extension hook methods are now protected](#hooks-protected)
- [Strict typing for `Factory` implementations](#factory-strict-typing)
- [General changes](#api-general)
- [Full list of removed and changed API (by module, alphabetically)](#api-removed-and-changed)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the name and anchor we gave this section for CMS 5.
Adding now so I can link to it.

@@ -181,10 +183,25 @@ SilverStripe\UserForms\Model\UserDefinedForm:

</details>

### Other new features
### Changes to the templating/view layer {#view-layer}
Copy link
Member Author

@GuySartorelli GuySartorelli Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Other new features" renamed and is now below the new section (more details in comment where it's being added).

Giving the new section a nice broad name because I'll use this section for the overall changelog info for the template layer refactor.

Comment on lines +200 to +201
### Other new features and small changes {#other-new-features}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed because the note about the default value isn't really a new feature, but there's also no need for it to have its own section.
Since this is a major release changelog it makes sense for things beyond just features to be in this section.


### Other new features and small changes {#other-new-features}

- Native indexed PHP arrays can now be passed into templates and iterated over with `<% loop $MyArray %>`. Under the hood they are wrapped in [`ArrayList`](api:SilverStripe\ORM\ArrayList), so you can get the count using `$Count` and use `<% if $ArrayList %>` as a shortcut for `<% if $ArrayList.Count %>`. Other functionality from `ArrayList` such as filtering and sorting cannot be used on arrays since they don't have keys to filter or sort against.
Copy link
Member Author

@GuySartorelli GuySartorelli Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just changing a link from ViewableData to ArrayList (original content is removed above the new section)

@GuySartorelli GuySartorelli force-pushed the pulls/6/strong-typing branch from 93bbce7 to f1b3677 Compare August 26, 2024 01:35
@GuySartorelli GuySartorelli marked this pull request as ready for review August 26, 2024 02:27
@emteknetnz emteknetnz merged commit ced3de0 into silverstripe:6 Aug 27, 2024
4 checks passed
@emteknetnz emteknetnz deleted the pulls/6/strong-typing branch August 27, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants