Merge pull request #316 from creative-commoners/pulls/2/stop-using-depr

API Stop using deprecated API
silverstripe · Dec 5, 2022 · 70f7275 · 70f7275
2 parents c716712 + 5542b38
commit 70f7275
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 7 deletions.
diff --git a/src/PageTypes/BasePage.php b/src/PageTypes/BasePage.php
@@ -95,12 +95,8 @@ public function getFooter()
         return FooterHolder::get_one(FooterHolder::class);
     }
 
-    /**
-     * @deprecated 2.2.0 Use RelatedPagesThrough() instead
-     */
     public function RelatedPages()
     {
-        Deprecation::notice('2.2.0', 'Use RelatedPagesThrough() instead');
         return $this->getManyManyComponents('RelatedPagesThrough');
     }
 

diff --git a/src/PageTypes/DatedUpdateHolder.php b/src/PageTypes/DatedUpdateHolder.php
@@ -154,7 +154,7 @@ public static function AllUpdates(
         } catch (DatabaseException $e) {
             self::handleInvalidDateFormat($e);
             // Ensure invalid SQL does not get run again
-            $items = $className::get()->limit(0);
+            $items = $className::get()->limit(null);
         }
 
         // Unpaginated DataList.

diff --git a/tests/PageTypes/DatedUpdateHolderControllerTest.php b/tests/PageTypes/DatedUpdateHolderControllerTest.php
@@ -20,7 +20,6 @@ protected function setUp(): void
 
         // Note: this test requires the starter theme to be installed
         Config::modify()->set(SSViewer::class, 'themes', ['starter', '$default']);
-        Config::modify()->set(SSViewer::class, 'theme', 'starter');
     }
 
     public function testSettingDateFiltersInReverseOrderShowsMessage()

diff --git a/tests/PageTypes/SitemapPageTest.php b/tests/PageTypes/SitemapPageTest.php
@@ -18,7 +18,6 @@ protected function setUp(): void
         parent::setUp();
 
         Config::modify()->set(SSViewer::class, 'themes', ['starter', '$default']);
-        Config::modify()->set(SSViewer::class, 'theme', 'starter');
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,6 @@ protected function setUp(): void @@
             parent::setUp();
             Config::modify()->set(SSViewer::class, 'themes', ['starter', '$default']);
-            Config::modify()->set(SSViewer::class, 'theme', 'starter');
         }
         /**
@@ Expand Down @@