Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Use node 18 #231

Merged
merged 1 commit into from
Sep 4, 2023
Merged

MNT Use node 18 #231

merged 1 commit into from
Sep 4, 2023

Conversation

emteknetnz
Copy link
Member

Issue #229

emteknetnz
emteknetnz commented Aug 31, 2023
View reviewed changes
src/js/components/content.js
@@ -3,7 +3,7 @@ import $ from 'jquery';
/* eslint-enable */

export default function () {
// Maori language class to add lang type
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix linting error

@emteknetnz emteknetnz mentioned this pull request Aug 31, 2023
Closed
GuySartorelli
GuySartorelli requested changes Sep 4, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@GuySartorelli GuySartorelli mentioned this pull request Sep 4, 2023
Merged
GuySartorelli
GuySartorelli requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS CI also failed.

package.json Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, looks good to me.

@GuySartorelli GuySartorelli merged commit a4d2ea1 into silverstripe:4 Sep 4, 2023
@GuySartorelli GuySartorelli deleted the pulls/4/node18 branch September 4, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli