Skip to content
This repository has been archived by the owner on Mar 15, 2023. It is now read-only.

Recipe should enforce the public webroot #10

Closed
robbieaverill opened this issue Jun 12, 2018 · 4 comments
Closed

Recipe should enforce the public webroot #10

robbieaverill opened this issue Jun 12, 2018 · 4 comments
Labels
affects/v4 change/patch effort/easy impact/medium type/bug Something isn't working

Comments

@robbieaverill
Copy link
Contributor

CWP 2.0 via the cwp-installer does enforce a public webroot but this recipe on its own doesn't - it should =)
@robbieaverill robbieaverill mentioned this issue Jun 12, 2018
Closed
@robbieaverill
Copy link
Contributor Author

@tractorcow if I add an empty file into public/ in this repository, will that mean that a public web root is always created when using this recipe on its own?

@tractorcow
Copy link

Yes, but only if the recipe is used as root.

@robbieaverill robbieaverill self-assigned this Mar 22, 2019
robbieaverill added a commit that referenced this issue Mar 22, 2019
@robbieaverill
Add empty public folder to ensure that public webroot is used in cwp-…
ca0f7ed 
…recipe-core by default

Fixes #10
robbieaverill added a commit to silverstripe/cwp-recipe-cms that referenced this issue Mar 22, 2019
@robbieaverill
Add empty public folder to ensure that public webroot is used in cwp-…
bbe633f 
…recipe-cwp by default

See silverstripe/cwp-recipe-core#10
@robbieaverill
Copy link
Contributor Author

This needs to be done in cwp-recipe-cms as well, because recipe-cms is installed before cwp-recipe-core is (see issue: silverstripe/recipe-plugin#12) so the public folder is created too late.

@robbieaverill
Copy link
Contributor Author

Fixed with ca0f7ed and silverstripe/cwp-recipe-cms@bbe633f

@robbieaverill robbieaverill removed their assignment Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects/v4 change/patch effort/easy impact/medium type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tractorcow @robbieaverill