NEW Import PDF export functionality from BasePage in cwp/cwp #1
Conversation
robbieaverill
force-pushed
the
pulls/1.0/import-from-cwp
branch
from
8d8cd31 to
d0fbb6a
Compare
|
Noted issue: clicking the "Export to PDF" link for a page initially fails with this message: Subsequent requests succeed and open the PDF. I suspect this could be a macOS issue with piping the wkhtmltopdf output to stdout. If we're happy, I think we should get this merge and raise that as a separate issue. We could write it to the PHP temp dir instead of piping to stdout. |
| } | ||
|
|
||
| if (!$binaryPath) { | ||
| user_error('Neither WKHTMLTOPDF_BINARY nor BasePage.wkhtmltopdf_binary are defined', E_USER_ERROR); |
There was a problem hiding this comment.
Error message needs to no reference BasePage anymore I think, it'll send people off on a wild goose chase.
There was a problem hiding this comment.
Yeah good call, will update
| return false; | ||
| } | ||
|
|
||
| $path = $this->owner->getPdfFilename(); |
There was a problem hiding this comment.
owner is going the long way around for this call.
There was a problem hiding this comment.
I think this follows the standard practice for extensions edited there's almost no reason to do this so may as well update it. Will push.
…taObject with extension
|
I've raised an issue for the error I noted above here: #2 |
Issue: silverstripe/cwp#31
Requires silverstripe/cwp#32