Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT ESLint issues #97

Merged

Conversation

sabina-talipova
Copy link
Contributor

Description

Turn on some of the ESLint.

Parent issue

@sabina-talipova sabina-talipova force-pushed the pulls/3/turn-on-eslint-rules branch from c777f19 to bc889b7 Compare June 30, 2023 00:24
@sabina-talipova sabina-talipova marked this pull request as ready for review July 3, 2023 02:11
@sabina-talipova sabina-talipova force-pushed the pulls/3/turn-on-eslint-rules branch from bc889b7 to f3650a5 Compare July 5, 2023 02:21
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit and PR prefix from FIX to MNT

@sabina-talipova sabina-talipova force-pushed the pulls/3/turn-on-eslint-rules branch from f3650a5 to 04c2d48 Compare July 7, 2023 04:03
@sabina-talipova sabina-talipova changed the title FIX ESLint issues MNT ESLint issues Jul 7, 2023
@emteknetnz emteknetnz merged commit dfdd95b into silverstripe:3 Jul 9, 2023
@emteknetnz emteknetnz deleted the pulls/3/turn-on-eslint-rules branch July 9, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants