Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove yarn test script #75

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 18, 2022

Fixes broken yarn test

https://github.com/silverstripe/cwp-agencyextensions/runs/7380644680?check_suite_focus=true#step:12:228

Which is failing because it's trying to run cwp-agencyextensions/vendor/silverstripe/admin/thirdparty/jquery-changetracker/spec/unit/spec.js

While that's obviously incorrect, there's actually no reason to run yarn test at all as this module has no js tests in it

There's a condition in gha-run-tests that mean yarn test does not run if there is no 'test' script in package.json

https://github.com/silverstripe/gha-run-tests/blob/1/action.yml#L200

        if [[ $(cat package.json | jq -r '.scripts.test') != 'null' ]]; then
          echo "Running yarn test"
          yarn run test
        fi

@GuySartorelli GuySartorelli merged commit a856223 into silverstripe:2.6 Jul 18, 2022
@GuySartorelli GuySartorelli deleted the pulls/2.6/broken-builds branch July 18, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants