Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Handle TLN commit prefix #248

Merged

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/.github#135

There's also an additional commit in here to disable the twig caching which is annoying as it requires the user to rm -rf /tmp/cow/twig/cache in order to get the twig template changes. Given this is so easy to miss it may mean we accidentally leave out the translation commits in a changelog in the future. There is seemingly zero performance difference with the caching disabled

The test this I created mock 5.1.1 release - I made this a patch release to ensure I didn't accidentally create new 5.2 branches

  • ensure cow .env file has DEV_MODE=1
  • cow release:create -vvv 5.1.1 silverstripe/recipe-kitchen-sink
  • cow release:plan -vvv 5.1.1 silverstripe/recipe-kitchen-sink
  • Update the readme in framework and add a commit 'TLN My translation commit'
  • cow release:changelog -vvv --skip-fetch-tags --include-other-changes --include-upgrade-only 5.1.1 silverstripe/recipe-kitchen-sink

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 589aee8 into silverstripe:master Nov 3, 2023
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/master/tln-prefix branch November 3, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants