Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#135
There's also an additional commit in here to disable the twig caching which is annoying as it requires the user to
rm -rf /tmp/cow/twig/cache
in order to get the twig template changes. Given this is so easy to miss it may mean we accidentally leave out the translation commits in a changelog in the future. There is seemingly zero performance difference with the caching disabledThe test this I created mock 5.1.1 release - I made this a patch release to ensure I didn't accidentally create new 5.2 branches