-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure the style guide is always accessible to all users #39
Make sure the style guide is always accessible to all users #39
Conversation
SilverStripe\Control\Director: | ||
rules: | ||
'_styleguide': false | ||
'styleguide': SilverStripe\Controllers\SimpleStyleguideController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm moving the route where the style guide is hosted to remove the underscore.
This is a temporary hack until benmanu/silverstripe-simple-styleguide#12 is merged. |
f3af1fb
to
126dace
Compare
Co-Authored-By: Andre Kiste <[email protected]>
I don't know what this fascination is with adding hacky overrides to project code, rather than running a fork with the pending pull requests merged in? It seems much easier to remove a fork once those pull requests are merged, rather than untangling whatever overrides we put in place (and if the same use cases are covered by the pull requests) |
I don't think it's much effort either way and I would rather avoid people coming across I've been burned with previous developers forking core SilverStripe module in the past to add some hacky features and a couple years down the line we're still maintaining the damn thing. My preference is weird override over forking in most cases. |
Right, but please subscribe to the pull requests to the |
This overrides the style guide controller with our own custom implementation that make the style guide publicly accessible on live environments.
Parent issue