Better styleguide template #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
maxime-rainville
force-pushed
the
pulls/styleguide-template
branch
from
a4c28d0 to
13df8aa
Compare
maxime-rainville
requested changes
Jul 22, 2019
|
Doh, it just gets the first available page as a base for rendering the styleguide: https://github.com/benmanu/silverstripe-simple-styleguide/blob/master/src/SimpleStyleguideController.php#L67 It should do the same as the Can you please merge this into our fork like the other two PRs we're still waiting for a merge on? |
maxime-rainville
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://app.zenhub.com/workspaces/open-sorcerers-52b2f493f0808b12020000f8/issues/silverstripe/bambusa-theme/3