Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix use statement to render proper class flags #92

Merged
merged 1 commit into from
Jan 4, 2021
Merged

fix use statement to render proper class flags #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
/en/
/htdocs
/data
/.vagrant/
1 change: 1 addition & 0 deletions conf/themes/silverstripe/class.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
{% endblock %}

{% block class_signature -%}
{% if class.final %}final {% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see your change, but please always check that this is not an upstream bug ;)

Fixed as: code-lts/doctum@4fae085
Confirmed on https://develdocs.phpmyadmin.net/phpmyadmin/PhpMyAdmin/DbTableExists.html

{% if not class.interface and class.abstract %}abstract {% endif %}
{{ class_category_name(class.getCategoryId()) }}
<strong>{{ class.shortname|raw }}</strong>
Expand Down
2 changes: 1 addition & 1 deletion src/Parser/SilverStripeNodeVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace SilverStripe\ApiDocs\Parser;

use Prophecy\Doubler\Generator\Node\ClassNode;
use PhpParser\Node\Stmt\Class_ as ClassNode;
use Doctum\Parser\NodeVisitor;
use PhpParser\Node\Stmt\ClassLike as ClassLikeNode;
use PhpParser\Node\Stmt\Property as PropertyNode;
Expand Down