Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Require Lookup directly to avoid needing PSR-4 autoloader #40

Merged

Conversation

robbieaverill
Copy link
Contributor

No description provided.

@fspringveldt fspringveldt merged commit 333e928 into silverstripe:master Jun 26, 2017
@robbieaverill robbieaverill deleted the pulls/4.0/hotfix-for-ssp branch June 26, 2017 22:18
@dhensby
Copy link
Contributor

dhensby commented Jul 19, 2017

I don't get why the autoloader wouldn't work on SSP :/

@andrewandante
Copy link
Contributor

@robbieaverill any chance you could fill me in on what this change is for? Is there something we are missing on SSP that should be happening, or is this a case of API being a special snowflake?

@robbieaverill
Copy link
Contributor Author

This was basically a hotfix because of a variety of reasons to do with using homer, I don't think it was SSP related at all. It was resolved in the end by dumping the composer autoloader manually using a command that disabled suhosin inline which was why composer wasn't working on the box. We can remove this if it's still there now :-)

@andrewandante
Copy link
Contributor

Alright, no worries - just saw the comment and thought maybe there was a bug with SSP, but if not that's great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants