Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to github in footer #65

Closed
chillu opened this issue Dec 14, 2017 · 4 comments · Fixed by #95
Closed

Link to github in footer #65

chillu opened this issue Dec 14, 2017 · 4 comments · Fixed by #95

Comments

@chillu
Copy link
Member

chillu commented Dec 14, 2017

We do this on docs as well. Without that link, people don't know where to report bugs, and realise they can actually help fixing them ;)

@williamdes
Copy link
Contributor

williamdes commented Dec 19, 2020

Implemented in 5.3.0 🚀

@williamdes
Copy link
Contributor

Deployed preview: https://williamdes.github.io/mariadb-mysql-kbs/

LGTM ✔️

@chillu
Copy link
Member Author

chillu commented Jan 4, 2021

@williamdes Awesome, thanks!

Would it be possible to make the footer link specific to the file path and repo that's currently being shown? It'd be a separate issue, just interested in the possibilities. So https://api.silverstripe.org/4/SilverStripe/AssetAdmin/BatchAction/DeleteAssets.html would point to https://github.com/silverstripe/silverstripe-asset-admin/blob/1/code/BatchAction/DeleteAssets.php, but https://api.silverstripe.org/4/SilverStripe/Admin/LeftAndMain.html would point to https://github.com/silverstripe/silverstripe-admin/blob/1/code/LeftAndMain.php

@williamdes
Copy link
Contributor

@williamdes Awesome, thanks!

Would it be possible to make the footer link specific to the file path and repo that's currently being shown? It'd be a separate issue, just interested in the possibilities. So https://api.silverstripe.org/4/SilverStripe/AssetAdmin/BatchAction/DeleteAssets.html would point to https://github.com/silverstripe/silverstripe-asset-admin/blob/1/code/BatchAction/DeleteAssets.php, but https://api.silverstripe.org/4/SilverStripe/Admin/LeftAndMain.html would point to https://github.com/silverstripe/silverstripe-admin/blob/1/code/LeftAndMain.php

Ah, this is the code link feature that is fixed in the other pull-request.

The footer is not to add a link to the source code but to add a link to go to a website or Github repo for the api docs for example

To sum up the feature you ask exists and is not the footer one, it should work after merging the other pull-request ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants