Support mysterious versions

silverstripe · Jan 4, 2021 · e6fb407 · e6fb407
1 parent fc7f94a
commit e6fb407
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/RemoteRepository/SilverStripeRemoteRepository.php b/src/RemoteRepository/SilverStripeRemoteRepository.php
@@ -26,7 +26,7 @@ public function getFileUrl($projectVersion, $relativePath, $line)
         }
         if (isset($packageConfig['versionmap'])) {
             $versionMaps = Config::getConfig()['versionmaps'];
-            $projectVersion = $versionMaps[$packageConfig['versionmap']][(string) $projectVersion];
+            $projectVersion = $versionMaps[$packageConfig['versionmap']][(string) $projectVersion] ?? $projectVersion;
         }
         $url = $rootPath . '/blob/' . $this->buildProjectPath($projectVersion, $pathParts[2]);
 

diff --git a/tests/SilverStripeRemoteRepositoryTest.php b/tests/SilverStripeRemoteRepositoryTest.php
@@ -48,5 +48,30 @@ public function testGetRepoUrl()
             . 'silverstripe-graphql/blob/master/src/Extensions/IntrospectionProvider.php#L0',
             $url
         );
+
+        $url = $remoteRepo->getFileUrl(
+            '3',
+            'silverstripe/graphql/src/Extensions/IntrospectionProvider.php',
+            0
+        );
+
+        $this->assertSame(
+            'https://github.com/silverstripe/'
+            . 'silverstripe-graphql/blob/3/src/Extensions/IntrospectionProvider.php#L0',
+            $url
+        );
+
+        // A mysterious version did pop out, oh snap
+        $url = $remoteRepo->getFileUrl(
+            'foobar',
+            'silverstripe/graphql/src/Extensions/IntrospectionProvider.php',
+            0
+        );
+
+        $this->assertSame(
+            'https://github.com/silverstripe/'
+            . 'silverstripe-graphql/blob/foobar/src/Extensions/IntrospectionProvider.php#L0',
+            $url
+        );
     }
 }