FIX Double backslashes do not result in double periods

silverstripe · Jul 3, 2017 · 5ba1b12 · 5ba1b12
1 parent 3244720
commit 5ba1b12
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Lookup.php b/src/Lookup.php
@@ -213,7 +213,7 @@ public function setUpgraderMap($map)
      */
     public function sanitiseNamespaces($class)
     {
-        return str_replace('\\', '.', ltrim($class, '\\'));
+        return preg_replace("/(\\\\+)/", '.', ltrim($class, '\\'));
     }
 
     /**

diff --git a/tests/LookupTest.php b/tests/LookupTest.php
@@ -73,6 +73,10 @@ public function handleProvider()
                 array('q' => '\Already\Fully\Qualified', 'version' => '3.4'),
                 'http://mockserver/3.4/class-Already.Fully.Qualified.html'
             ),
+            array(
+                array('q' => '\\\\Already\\\\Fully\\\\Qualified', 'version' => '3.4'),
+                'http://mockserver/3.4/class-Already.Fully.Qualified.html'
+            ),
             array(
                 array('q' => 'Director', 'module' => 'framework'),
                 'http://mockserver/master/class-SilverStripe.Control.Director.html'
-Original file line number
+Diff line change
@@ Expand Up / @@ -213,7 +213,7 @@ public function setUpgraderMap($map) @@
          */
         public function sanitiseNamespaces($class)
         {
-            return str_replace('\\', '.', ltrim($class, '\\'));
+            return preg_replace("/(\\\\+)/", '.', ltrim($class, '\\'));
         }
         /**
@@ Expand Down @@