Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Use class name instead of self #27

Merged
merged 1 commit into from
Jun 17, 2024
Merged

ENH Use class name instead of self #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/FacebookWebDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class FacebookWebDriver extends CoreDriver
* @param string $wdHost The WebDriver host
*/
public function __construct(
$browserName = self::DEFAULT_BROWSER,
$browserName = FacebookWebDriver::DEFAULT_BROWSER,
$desiredCapabilities = [],
$wdHost = 'http://localhost:4444/wd/hub'
) {
Expand Down Expand Up @@ -172,7 +172,7 @@ protected function getBrowserName()
* @param string $browserName the name of the browser to start, default is 'chrome'
* @return $this
*/
protected function setBrowserName($browserName = self::DEFAULT_BROWSER)
protected function setBrowserName($browserName = FacebookWebDriver::DEFAULT_BROWSER)
{
$this->browserName = $browserName;
return $this;
Expand Down Expand Up @@ -265,9 +265,9 @@ public function setWebDriver(RemoteWebDriver $webDriver)
public static function getDefaultCapabilities()
{
return [
'browserName' => self::DEFAULT_BROWSER,
'browserName' => FacebookWebDriver::DEFAULT_BROWSER,
'platform' => 'ANY',
'browser' => self::DEFAULT_BROWSER,
'browser' => FacebookWebDriver::DEFAULT_BROWSER,
'name' => 'Behat Test',
'deviceOrientation' => 'portrait',
'deviceType' => 'tablet',
Expand Down Expand Up @@ -954,7 +954,7 @@ public function blur($xpath)
*/
public function keyPress($xpath, $char, $modifier = null)
{
$options = self::charToOptions($char, $modifier);
$options = FacebookWebDriver::charToOptions($char, $modifier);
$this->trigger($xpath, 'keypress', $options);
}

Expand All @@ -963,7 +963,7 @@ public function keyPress($xpath, $char, $modifier = null)
*/
public function keyDown($xpath, $char, $modifier = null)
{
$options = self::charToOptions($char, $modifier);
$options = FacebookWebDriver::charToOptions($char, $modifier);
$this->trigger($xpath, 'keydown', $options);
}

Expand All @@ -972,7 +972,7 @@ public function keyDown($xpath, $char, $modifier = null)
*/
public function keyUp($xpath, $char, $modifier = null)
{
$options = self::charToOptions($char, $modifier);
$options = FacebookWebDriver::charToOptions($char, $modifier);
$this->trigger($xpath, 'keyup', $options);
}

Expand Down
Loading