Add support for Silverstripe 5 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispenny
force-pushed
the
feature/silverstripe-5
branch
from
8a905fe to
42f146e
Compare
chrispenny
force-pushed
the
feature/silverstripe-5
branch
from
42f146e to
e502fe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Added property type declarations, which will be a breaking change for anyone extending
SwiftypeMetaTagorSwiftypeSiteTreeCrawlerExtension.Dependencies
Raised dependencies to match the minimum requirements of Silverstripe 5.
Unit test changes
Silverstripe 5 now does not include trailing slashes by default. Simple enough, our tests just had to be updated to not have trailing slashes.
Fixing some
Configmodification to use the newset()method.Moved tests out of the
phpdirectory. We only have php tests...