Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove data-setup property to prevent double initialization (#70) #83

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

izkmdz
Copy link
Contributor

@izkmdz izkmdz commented Feb 22, 2022

Using the data-setup attribute in the video component will automatically initialize the player with the options provided. However, if the player is also initialized in our code using the videojs('my-player') function, this can sometimes cause the issue described in #70, where the quality selector is unable to change sources.

These changes remove the data-setup attribute from the documentation and demo to prevent this from occuring.

@coveralls
Copy link

coveralls commented Feb 22, 2022

Coverage Status

Coverage remained the same at 0.0% when pulling 613e311 on izkmdz:ismendoza/remove-data-setup into 8b1a082 on silvermine:master.

README.md Outdated Show resolved Hide resolved
@izkmdz izkmdz force-pushed the ismendoza/remove-data-setup branch from 6a59753 to 72bb456 Compare February 23, 2022 17:13
README.md Show resolved Hide resolved
@izkmdz izkmdz force-pushed the ismendoza/remove-data-setup branch from 72bb456 to 613e311 Compare February 28, 2022 18:27
@yokuze yokuze merged commit df38cde into silvermine:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants