Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace node-sass with sass and rename folder containing SCSS #80

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Replace node-sass with sass and rename folder containing SCSS #80

merged 2 commits into from
Apr 7, 2022

Conversation

izkmdz
Copy link
Contributor

@izkmdz izkmdz commented Feb 15, 2022

No description provided.

@coveralls
Copy link

coveralls commented Feb 15, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 0.0% when pulling 5cf15e5 on izkmdz:ismendoza/update-sass into df38cde on silvermine:master.

yokuze
yokuze requested changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@yokuze yokuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment. Thanks for the PR.

package.json Outdated Show resolved Hide resolved
@izkmdz izkmdz force-pushed the ismendoza/update-sass branch from d0a460a to 6f15d67 Compare February 21, 2022 23:24
yokuze
yokuze reviewed Apr 4, 2022
View reviewed changes
Copy link
Contributor

@yokuze yokuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this in the last review, but this path needs to be updated: https://github.com/silvermine/videojs-quality-selector/pull/80/files#diff-8e7e5f941c67b0cf481a9d650295119d4922b96117e7adc069ba30a81a78c65fR26

yokuze
yokuze requested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@yokuze yokuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the build with the changes in this PR results in no CSS output because of an incorrect path in the Gruntfile. See: #80 (review)

@izkmdz izkmdz force-pushed the ismendoza/update-sass branch from 6f15d67 to 5cf15e5 Compare April 6, 2022 22:25
@yokuze yokuze merged commit 32fac40 into silvermine:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yokuze yokuze yokuze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izkmdz @coveralls @yokuze