Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable automatic insertion of AirPlay button into the player's control bar #5

Closed
yokuze opened this issue Dec 1, 2017 · 1 comment

Comments

@yokuze
Copy link
Contributor

yokuze commented Dec 1, 2017

We should add a configuration option that allows users to disable the automatic insertion of the AirPlay button into the player's control bar.

Plugin users may want to specify where the AirPlay button appears in the player UI's component hierarchy using Video.js configuration options. With the way the plugin is now, the AirPlay button will be inserted into the control bar if the plugin does not find it at the root level of the controlBar component. If a plugin user specifies the AirPlay button to appear nested within an element in the controlBar, for example, the plugin will insert another AirPlay button at the root controlBar level.

yokuze added a commit to yokuze/videojs-airplay that referenced this issue Dec 1, 2017
Adds the option to allow plugin users to disable automatically inserting
the AirPlayButton component into the player's ControlBar component.
yokuze added a commit to yokuze/videojs-airplay that referenced this issue Dec 1, 2017
Adds the option to allow plugin users to disable automatically inserting
the AirPlayButton component into the player's ControlBar component.
yokuze added a commit to yokuze/videojs-airplay that referenced this issue Dec 1, 2017
Adds the option to allow plugin users to disable automatically inserting
the AirPlayButton component into the player's ControlBar component.
jthomerson added a commit that referenced this issue Dec 1, 2017
…option_5

Refs #5 Add addButtonToControlBar option
@yokuze
Copy link
Contributor Author

yokuze commented Dec 21, 2018

Closed with #6

@yokuze yokuze closed this as completed Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant