Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support localized control text for the AirPlay button #3

Closed
yokuze opened this issue Oct 25, 2017 · 0 comments
Closed

Support localized control text for the AirPlay button #3

yokuze opened this issue Oct 25, 2017 · 0 comments

Comments

@yokuze
Copy link
Contributor

yokuze commented Oct 25, 2017

Currently, the AirPlay plugin allows you to pass a string literal option called buttonText that becomes the button's .vjs-control-text text. However, the AirPlay Button component overrides the createControlTextEl method and does not add the aria-label to the button as its parent does.

A simpler method would be to call this.controlText('Start AirPlay') from the constructor, and let the Button component handle adding the control text. This has the added advantage of integrating with Video.js' localization API.
yokuze added a commit to yokuze/videojs-airplay that referenced this issue Oct 25, 2017
@yokuze
Fixes silvermine#3 Use localized text for the AirPlay button's access…
788e473 
…ibility text
jthomerson added a commit that referenced this issue Oct 25, 2017
@jthomerson
Merge pull request #4 from yokuze/localize_control_text_3
169d5e3 
Fixes #3 Use localized text for the AirPlay button's accessibility text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yokuze