Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitplaybacktargetavailabilitychanged listener is not removed when AirPlayButton is disposed #29

Closed
ddunkin opened this issue Sep 10, 2020 · 3 comments
Closed

webkitplaybacktargetavailabilitychanged listener is not removed when AirPlayButton is disposed #29

ddunkin opened this issue Sep 10, 2020 · 3 comments

Comments

@ddunkin
Copy link

ddunkin commented Sep 10, 2020

The event listener is not removed when the AirPlayButton is disposed, so if the event is raised, AirPlayButton tries to hide or show itself, but this._el is null and an error is throw.
izkmdz added a commit to izkmdz/videojs-airplay that referenced this issue Feb 9, 2022
@izkmdz
fix: Remove target availability event listener on dispose (silvermine#29
618e35e 
)

Fix for issue silvermine#29.

This commit removes the "webkitplaybacktargetavailabilitychanged" event listener when the component is disposed. It also provides a test case demo in which the user can remove (dispose) the AirPlay component from the videoJS player.
@izkmdz izkmdz mentioned this issue Feb 9, 2022
Merged
izkmdz added a commit to izkmdz/videojs-airplay that referenced this issue Feb 14, 2022
@izkmdz
fix: Remove target availability event listener on dispose (silvermine#29
52bb4e2 
)

Fix for issue silvermine#29.

This commit removes the "webkitplaybacktargetavailabilitychanged" event listener when the component is disposed. It also provides a test case demo in which the user can remove (dispose) the AirPlay component from the videoJS player.
izkmdz added a commit to izkmdz/videojs-airplay that referenced this issue Feb 14, 2022
@izkmdz
fix: Remove target availability event listener on dispose (silvermine#29
d20dc68 
)

Fix for issue silvermine#29.

This commit removes the "webkitplaybacktargetavailabilitychanged"
event listener when the component is disposed. It also provides a
test case demo in which the user can remove (dispose) the AirPlay
component from the videoJS player.
izkmdz added a commit to izkmdz/videojs-airplay that referenced this issue Feb 23, 2022
@izkmdz
fix: Remove target availability event listener on dispose (silvermine#29
83b91bb 
)

Fix for issue silvermine#29.

This commit removes the "webkitplaybacktargetavailabilitychanged"
event listener when the component is disposed. It also provides a
test case demo in which the user can remove (dispose) the AirPlay
component from the videoJS player.
izkmdz added a commit to izkmdz/videojs-airplay that referenced this issue Feb 24, 2022
@izkmdz
fix: Remove target availability event listener on dispose (silvermine#29
f732699 
)

Fix for issue silvermine#29.

This commit removes the "webkitplaybacktargetavailabilitychanged"
event listener when the component is disposed. It also provides a
test case demo in which the user can remove (dispose) the AirPlay
component from the videoJS player.
yokuze added a commit that referenced this issue Feb 24, 2022
@yokuze
Merge pull request #35 from izkmdz/ismendoza/fix-dispose-listener
c83a600 
fix: Remove target availability event listener on dispose (#29)
@kontrollanten
Copy link

We've issues with this as well. @izkmdz Can you create a pull request with your fix?

@yokuze
Copy link
Contributor

yokuze commented Jul 20, 2022

We've issues with this as well. @izkmdz Can you create a pull request with your fix?

#35 Should have taken care of it @kontrollanten. We are actively working in this repo over the next month or so, so won't publish a new version just yet. For now, you could NPM install using a git+ssh / git+https url with the latest master hash, if you'd like.

@yokuze yokuze closed this as completed Jul 20, 2022
@kontrollanten
Copy link

Oh, great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ddunkin @yokuze @kontrollanten